GWJ bugs, feature requests, and updates

doogiemac wrote:
Just rolled out a couple fixes:
  • Favorites page is now fluid width.
  • Favorites page now sorts by last comment date, just like the tracker.
  • Favorites link got moved up in the header so it doesn't make Stan sad.
  • When you mark a post as a favorite, you are now returned to the page you were on in the thread.

Thanks, @joshdw1 for the help on these fixes.

I'm curious as to what "fluid width" means. Like the forums? Because the favorites page looks exactly the same as before to me. On Chrome stable. Love the other changes, though!

Any plans to change the top banner on the mobile version? It's been reported above to break things on both Android and iOS.

Hyetal wrote:
doogiemac wrote:
Just rolled out a couple fixes:
  • Favorites page is now fluid width.
  • Favorites page now sorts by last comment date, just like the tracker.
  • Favorites link got moved up in the header so it doesn't make Stan sad.
  • When you mark a post as a favorite, you are now returned to the page you were on in the thread.

Thanks, @joshdw1 for the help on these fixes.

I'm curious as to what "fluid width" means. Like the forums? Because the favorites page looks exactly the same as before to me. On Chrome stable. Love the other changes, though!

That was a CSS change, so you may need to clear your browser cache to see the difference.

Veloxi wrote:
Sorry if this was asked before, don't have the patience to check all 14 pages, but is there any way to get these forums on a mobile app like Tapatalk, for example? If not, could there be at some point? Thanks!

Seconding, I asked about this a while ago and I'd still really like to see it happen. As far as I can tell the process to activate a forum is relatively simple.

Does all the new functionality imply we are running a version of the forum software that might allow this now?

Happy Dave wrote:
Veloxi wrote:
Sorry if this was asked before, don't have the patience to check all 14 pages, but is there any way to get these forums on a mobile app like Tapatalk, for example? If not, could there be at some point? Thanks!

Seconding, I asked about this a while ago and I'd still really like to see it happen. As far as I can tell the process to activate a forum is relatively simple.

Does all the new functionality imply we are running a version of the forum software that might allow this now?

I think this forum is not in a supported format like vBulletin. That hasn't changed. So it's not that simple.

Kosars wrote:
That was a CSS change, so you may need to clear your browser cache to see the difference.

Thank you, kind sir. Works perfectly now.

doogiemac wrote:
Just rolled out a couple fixes:
  • Favorites page is now fluid width.
  • Favorites page now sorts by last comment date, just like the tracker.
  • Favorites link got moved up in the header so it doesn't make Stan sad.
  • When you mark a post as a favorite, you are now returned to the page you were on in the thread.

Thanks, @joshdw1 for the help on these fixes.

Thanks a bunch. looks great now.

Thank you!

MannishBoy wrote:
Any plans to change the top banner on the mobile version? It's been reported above to break things on both Android and iOS.

IE Mobile, too, for what it's worth.

I'm just popping back in to say that the favorites feature is probably my favorite thing ever.

Being able to browse the forums without filtering through the threads I will never, ever open to get to the ones I want is great. It actually works in a satisfactory way unlike the "recent posts" tracker, which just doesn't work at all for the way I read forums.

<3

Thanks for implementing this.

doogiemac wrote:
Just rolled out a couple fixes:
  • Favorites page is now fluid width.
  • Favorites page now sorts by last comment date, just like the tracker.
  • Favorites link got moved up in the header so it doesn't make Stan sad.
  • When you mark a post as a favorite, you are now returned to the page you were on in the thread.

Thanks, @joshdw1 for the help on these fixes.

You forgot the most important one to me, which is that the links to new comments from the Favorites page now work.

Kosars wrote:
Glad everyone is liking the new stuff, exciting to see it on the site!

BadMojo wrote:
To add more specificity to my concern with the favorites:

Link to new posts for a thread form the favorites page: http://www.gamerswithjobs.com/node/1...
Link to new posts for a thread from the track page: http://www.gamerswithjobs.com/node/1...

I had tested that, I must have broken the links later I guess, will get a fix for it.

This is not quite fixed yet. The link now goes to the last page with new comments, not the first page with new comments. So if there are new comments on page=28, page=29, and page=30, the generated link will say page=30#new, but ought to say page=28#new.

Thin_J wrote:
I'm just popping back in to say that the favorites feature is probably my favorite thing ever.

Being able to browse the forums without filtering through the threads I will never, ever open to get to the ones I want is great. It actually works in a satisfactory way unlike the "recent posts" tracker, which just doesn't work at all for the way I read forums.

<3

Thanks for implementing this.

^^^ what he said. It's like having your own personal GWJ

Katy wrote:
This is not quite fixed yet. The link now goes to the last page with new comments, not the first page with new comments. So if there are new comments on page=28, page=29, and page=30, the generated link will say page=30#new, but ought to say page=28#new.

Wait wait wait. Wait.

...

Wait.

So, what you're saying here is that there are people who don't visit so often that there's never more than one page of new posts in their favorite threads?

Thin_J wrote:
Katy wrote:
This is not quite fixed yet. The link now goes to the last page with new comments, not the first page with new comments. So if there are new comments on page=28, page=29, and page=30, the generated link will say page=30#new, but ought to say page=28#new.

Wait wait wait. Wait.

...

Wait.

So, what you're saying here is that there are people who don't visit so often that there's never more than one page of new posts in their favorite threads?

:shock:

Stop making the threads longer so fast!

Oh crap! I just did it!

Oh crap! I just did it ... again ... by accident.

Thin_J wrote:
So, what you're saying here is that there are people who don't visit so often that there's never more than one page of new posts in their favorite threads?

:shock:

Have you seen the Skyrim thread(s) or the TF2 thread lately?

Don't be such a slacker. Keep up.

The Skyrim thread moves at light speed. No joke, I stopped watching it for half an hour and it jumped 97 posts. 97.

So just stopped by to say nice job on the new changes... Thanks for the favorites!!! LOVE IT!!!

Katy wrote:
Kosars wrote:
Glad everyone is liking the new stuff, exciting to see it on the site!

BadMojo wrote:
To add more specificity to my concern with the favorites:

Link to new posts for a thread form the favorites page: http://www.gamerswithjobs.com/node/1...
Link to new posts for a thread from the track page: http://www.gamerswithjobs.com/node/1...

I had tested that, I must have broken the links later I guess, will get a fix for it.

This is not quite fixed yet. The link now goes to the last page with new comments, not the first page with new comments. So if there are new comments on page=28, page=29, and page=30, the generated link will say page=30#new, but ought to say page=28#new.

Sorry, silly mistake on my part, I've sent in another fix that should hopefully take care of this once and for all

It's nice to have live testers

Yay, thanks for the changes! Favorites works awesome now!

Kosars wrote:
Sorry, silly mistake on my part, I've sent in another fix that should hopefully take care of this once and for all :)

You still have a fencepost error if the first new post is the last post on a page. (I saw this, but did not test extensively, as I'm using the mobile site at the moment. )

edit -- never mind. I see this was addressed above.

Katy wrote:
Kosars wrote:
Sorry, silly mistake on my part, I've sent in another fix that should hopefully take care of this once and for all :)

You still have a fencepost error if the first new post is the last post on a page. (I saw this, but did not test extensively, as I'm using the mobile site at the moment. )

And the other change you put in seems to have been reverted, and the Favorites page "new" text is back to pointing at 'new posts on the last page of posts'.

You know, if you could figure out a way to get the IMG tag to encode the height/width of an uploaded image, it would really improve the scanning of the forums. Hardly anyone ever bothers to size their tag correctly (I'm almost the only one that does), so their huge screenshots always blow the threads to hell until you reload.

It'd be really cool if the server could be smart enough to use something like imagemagick to figure out how big the uploaded image was, and embed that in the img tag.

Just deployed a fix (courtesy of @joshdw1) that should address the favorites list always linking to the last page (should now link to the appropriate page for the earliest unread comment).

Malor wrote:
You know, if you could figure out a way to get the IMG tag to encode the height/width of an uploaded image, it would really improve the scanning of the forums. Hardly anyone ever bothers to size their tag correctly (I'm almost the only one that does), so their huge screenshots always blow the threads to hell until you reload.

It'd be really cool if the server could be smart enough to use something like imagemagick to figure out how big the uploaded image was, and embed that in the img tag.

Sadly, I don't see any reasonable way to pull down the image sizes. However, that shouldn't be needed. I've just been lazy in putting together the fix to make it not blow the page layouts. I'll see if I can find some time.

I thought that the images already auto resize.